Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add github workflow pre-commit.yml #15

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

betmoar
Copy link
Owner

@betmoar betmoar commented Nov 29, 2024

This pull request introduces a new GitHub Actions workflow to automate pre-commit checks. The workflow is configured to run on every push and pull request, ensuring that the code adheres to defined standards before merging.

Key changes include:

  • .github/workflows/pre-commit.yml: Added a new workflow named "Pre-commit checks" that runs on push and pull_request events. The workflow sets up an Ubuntu environment, checks out the code, sets up Python 3.8, installs necessary dependencies, and runs pre-commit hooks.

@betmoar betmoar requested a review from Copilot November 29, 2024 19:39

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.

- Ensure proper cleanup of keys in storage based on invalidation strategies.
- Add error handling and logging for composite cleanup and invalidation checks.
- Improve logging for strategy-based invalidation decisions.
@betmoar betmoar marked this pull request as draft November 29, 2024 20:15
@betmoar betmoar marked this pull request as ready for review November 29, 2024 20:16
@betmoar betmoar requested a review from Copilot November 29, 2024 20:16

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 10 out of 24 changed files in this pull request and generated no suggestions.

Files not reviewed (14)
  • tracklistify/config/base.py: Evaluated as low risk
  • tracklistify/providers/acrcloud.py: Evaluated as low risk
  • .github/workflows/pre-commit.yml: Evaluated as low risk
  • tracklistify/config/docs.py: Evaluated as low risk
  • tests/test_config.py: Evaluated as low risk
  • tests/test_rate_limiter.py: Evaluated as low risk
  • tests/test_track_matcher.py: Evaluated as low risk
  • tracklistify/cache/invalidation.py: Evaluated as low risk
  • tracklistify/exporters/spotify.py: Evaluated as low risk
  • tracklistify/downloaders/youtube.py: Evaluated as low risk
  • tracklistify/config/validation.py: Evaluated as low risk
  • tracklistify/downloaders/spotify.py: Evaluated as low risk
  • tracklistify/exporters/tracklist.py: Evaluated as low risk
  • tracklistify/core/run.py: Evaluated as low risk
Comments skipped due to low confidence (4)

tracklistify/config/security.py:187

  • The use of 'strict=True' in the zip function requires Python 3.10 or later. Ensure the project uses Python 3.10 or later, or remove the 'strict=True' parameter.
xored = bytes(a ^ b for a, b in zip(block, prev_block, strict=True))

tracklistify/config/security.py:189

  • The use of 'strict=True' in the zip function requires Python 3.10 or later. Ensure the project uses Python 3.10 or later, or remove the 'strict=True' parameter.
encrypted = bytes(a ^ b for a, b in zip(xored, key[:16], strict=True))

tracklistify/config/security.py:223

  • The use of 'strict=True' in the zip function requires Python 3.10 or later. Ensure the project uses Python 3.10 or later, or remove the 'strict=True' parameter.
decrypted = bytes(a ^ b for a, b in zip(block, key[:16], strict=True))

tracklistify/config/security.py:225

  • The use of 'strict=True' in the zip function requires Python 3.10 or later. Ensure the project uses Python 3.10 or later, or remove the 'strict=True' parameter.
xored = bytes(a ^ b for a, b in zip(decrypted, prev_block, strict=True))
@betmoar betmoar closed this Nov 29, 2024
@betmoar betmoar reopened this Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant