Add advanced entity outline calculations #222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes add sophisticated AABB (Axis-Aligned Bounding Box) calculations for accurately drawing outlines around selected entities, handling various entity types like meshes and sprites, and properly accounting for hierarchies and transformations.
The change extracts multiple queries used in the outline gizmo system into a dedicated `OutlineGizmoQueries` struct that implements `SystemParam`
|
@alice-i-cecile happy to get this merged in, thought it might be better to call this a |
|
I like |
|
I'll get back to this soon. Seems I might have to change the file name and remove some implementations from the |
The changes are focused on renaming the outline gizmo functionality to selection box, which includes renaming the module, component, functions and UI text for better clarity and consistency.
tim-blackbird
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes add sophisticated AABB (Axis-Aligned Bounding Box) calculations for accurately drawing outlines around selected entities, handling various entity types like meshes and sprites, and properly accounting for hierarchies and transformations.
#221