Ensure SchemaInfo.Schema.Default is non-nil if it is really set #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In prior implementation, if the schema type is one of int/bool/string, the `.Schema.Default` might not be set if the `Default` is not set to a BasicLiteral(for int/string) or a bool Ident (for bool). It is a very popular case that the default value of a string property is set to an expression that is to convert the type from another string aliased type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In prior implementation, if the schema type is one of int/bool/string,
the
.Schema.Defaultmight not be set if theDefaultis not set to aBasicLiteral(for int/string) or a bool Ident (for bool). It is a very
popular case that the default value of a string property is set to an
expression that is to convert the type from another string aliased type.