fix: Ensure dotfiles are always filtered #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shnizzedy could I trouble you or one of your group for a review? |
Coerce ignore to list to handle other sequence types (tuples) being passed.
effigies
force-pushed
the
fix/ignore-dotfiles
branch
from
7362964 to
5a34b83
Compare
Closes bids-standardgh-925 by passing without requiring a fix.
|
Added an extra test to take advantage of the new fixture. It's unrelated but closes an additional issue. |
mgxd
approved these changes
Mar 5, 2025
shnizzedy
reviewed
Mar 5, 2025
|
Thanks! Post-merge reviews are always welcome, even (especially) when I'm rushing a bit. |
effigies
added a commit
that referenced
this pull request
Mar 13, 2025
Version 0.19.0 (March 05, 2025) New feature release in the 0.19.x series. This release adds plus signs to labels and suffixes, anticipating the release of BIDS 1.10.1 or 1.11.0 (whichever is next). Until the BIDS specification is updated and the ``bidsschematools`` package containing the updated schema is published, files with ``+`` will not validate, but can still be indexed with ``BIDSLayout(..., validate=False)``. Several small fixes resolving issues with BIDS Stats Models are included, and complex JSON metadata (lists and objects) will now play more nicely with contexts where they need to be hashed. * FIX: Catch StopIteration on directory walk (#1124) * FIX: Ensure dotfiles are always filtered (#1123) * FIX: Copy entities dict before modifying run variable type (#1120) * FIX: Allow numpy arrays to treat PaddedInt like int (#1119) * FIX: Make lists and dicts hashable (#1112) * ENH: Allow plus signs in labels (#1117) * MNT: Remove formulaic upper bound (#1121) * MNT: Use tox-uv to ease lower bound checking, test on Python 3.13 (#1109)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dotfiles are ignored by default, but custom ignore patterns override the default ignores. This change ensures that dotfiles are always ignored in either case.
Regression test reproduces #1069 and patch fixes it.
Closes #1069.