fix: "Auto Detect" breaks closed captions w/ Gladia - Handle auto locale#20
Open
gschwienbacher wants to merge 2 commits intobigbluebutton:developmentfrom
Open
fix: "Auto Detect" breaks closed captions w/ Gladia - Handle auto locale#20gschwienbacher wants to merge 2 commits intobigbluebutton:developmentfrom
gschwienbacher wants to merge 2 commits intobigbluebutton:developmentfrom
Conversation
…adia BBB core sends locale "auto" when the user selects "Auto detect" for live transcription. This value was passed through to Gladia's API verbatim, which rejected it since "auto" is not a valid ISO 639-1 language code. The old bbb-transcription-controller handled this by stripping the language field so Gladia would fall back to server-side auto-detection, but this handling was lost in the migration to LiveKit. - _sanitize_locale() now returns None for "auto" locale - start_transcription_for_user() omits the language param when None, triggering Gladia's built-in auto-detection - update_locale_for_user() sends empty languages list for auto locale - Transcript handlers in main.py resolve BBB locale via the translation map when original locale is "auto" instead of comparing against it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #15
(and replaces #14)
I was in contact w/ @lrossillon-gladia and am bringing in the changes as I've already signed the CLA.
Credits to @lrossillon-gladia
Summary
autoas Gladia auto-detection instead of passing an invalid language codelanguageargument and send an emptylanguageslist on locale updatesautoin transcript locale resolution and add regression testsTesting
uvis not installed in this shell)