Skip to content

Conversation

carsonreinke
Copy link

What?

Some responses incorrectly throw error messages because there is a type mismatch on the arguments to the error constructors. Basically, json_decode on the response body is not guaranteed to return a string. We need to enforce the string.

Writing test cases involved a lot of work unless a curl abstraction was built/used. Even mocking is extremely difficult here.

Tickets / Documentation

#223

Screenshots (if appropriate)

None

cc @jofomah

@carsonreinke carsonreinke changed the title Fixes #223 Need to force string when constructing error clases Nov 4, 2019
@carsonreinke carsonreinke changed the title Need to force string when constructing error clases Need to force string when constructing error classes Nov 12, 2019
@carsonreinke
Copy link
Author

carsonreinke commented Mar 16, 2020

Hello? @bookernath

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant