doc(promotions): DEVDOCS-6652 add maximum_allowed_discount_amount to … #1201
Conversation
bc-vincent-zhao
force-pushed
the
promotion_max_discount
branch
from
96eb2fe to
1bcabc5
Compare
| The maximum monetary value that can be applied as a discount. It can take value from 1 to 10000000. | ||
| The application of this maximum depends on the discount type: | ||
| - Discount on shipping: the max limit is distributed to the first number of shipping destinations until it is reached | ||
| - Discount on products: the max limit is distributed to the first number of eligible products until it is reached |
There was a problem hiding this comment.
probably we need to double check if this aligns with the project's description: https://bigcommercecloud.atlassian.net/browse/PROJECT-7350
There was a problem hiding this comment.
Thanks Donald for noticing this 🙇 , it is indeed different from the original PR Anshu prepared, I changed the description here deliberately based on the latest discussion and actual implementation of the feature.
For example: when we have a $10 off each product, maximum $20 promotion and we have 3 items each cost $100, the resulting discount would be $10 discount for the first 2 items (there's no weighted distribution) cc @bc-chaozhang
more examples can be found at https://github.com/bigcommerce/bigcommerce/blob/master/tests/Integration/Promotion/CartItemDiscountMaximumAllowedTest.php
@bc-jwk has tested the behaviour extensively and he's ok with the current behaviour
There was a problem hiding this comment.
thanks for confirmation Vincent, probably worth updating the Project description to latest info so would be easier for future references 🙇
There was a problem hiding this comment.
Leaving a comment here for posterity.
The current implementation and behaviour is acceptable since the lift to introduce isn't too complex and we avoid making huge changes to the engine. Plus it should really fit the majority of use cases based on the feedback we've received.
We will release this into the wild and iterate when necessary if we receive different feedback.
bc-vincent-zhao
dismissed stale reviews from denis-bc, YevenLourance, and donald-nguyen-bc
via
cd20e61
bc-terra
left a comment
bc-terra
left a comment
There was a problem hiding this comment.
compiles without issue. looks good. straightforward explanation
…promotion api
DEVDOCS-6652
What changed?
add
maximum_allowed_discount_amountfield to the promotion apiRelease notes draft
ping @bigcommerce/team-promotions @bc-jwk @bigcommerce/dev-docs