Skip to content

Conversation

@HussainAther
Copy link

Splits t/Species.t into modular test files for maintainability:

  • t/Species/basic.t – basic method and constructor tests
  • t/Species/memory.t – memory leak and regression tests
  • t/Species/taxonomy_db.t – Entrez Taxonomy DB fetch tests (with skip)

This supports clearer test separation and easier maintenance going forward.

@hlapp hlapp requested a review from Copilot June 2, 2025 00:27
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the existing t/Species.t into modular test files for clarity and maintainability, adds focused memory-leak and taxonomy database tests, and introduces dedicated interface tests for Bio::SeqI and Bio::AnnotationI.

  • Split species tests into three files: basic functionality, memory regressions, and Entrez DB integration.
  • Added standalone tests for Bio::SeqI and Bio::AnnotationI.
  • Ensured network-dependent tests are skipped cleanly when unavailable.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
t/Species/basic.t Core constructor, binomial, genus, and subspecies behavior tests
t/Species/memory.t Memory-leak checks and regressions using Test::Memory::Cycle & Weaken
t/Species/taxonomy_db.t Entrez Taxonomy database fetch tests with skip on network failures
t/SeqI.t Interface compliance tests for Bio::SeqI
t/AnnotationI.t Interface compliance tests for Bio::AnnotationI
Comments suppressed due to low confidence (1)

t/Species/basic.t:4

  • The test plan declares 8 tests, but only 7 assertions are present. Please adjust the test count or add the missing test.
use Test::More tests => 8;

Please update to include recommended Copilot change

Co-authored-by: Copilot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants