Skip to content

Add CLePAPS structural alphabet - #681

Merged
padix-key merged 1 commit into
biotite-dev:mainfrom
padix-key:clepaps
Jul 21, 2026
Merged

Add CLePAPS structural alphabet#681
padix-key merged 1 commit into
biotite-dev:mainfrom
padix-key:clepaps

Conversation

@padix-key

@padix-key padix-key commented Oct 19, 2024

Copy link
Copy Markdown
Member

This PR adds support for the CLePAPS structural alphabet (https://doi.org/10.1142/s0219720008003461).

This PR is currently on hold as the obtained sequences do not fit the sequences from the reference implementation (taken from presentation slides as the original software is not available anymore). Curiously the centers of the clustered bending angles do not exceed 90°. Hence, I wonder if the centers given in the paper are correct

I found two misunderstandings between my code and the definitions in the paper. With these resolved and can reproduce almost all symbols from the reference sequences.

@padix-key padix-key mentioned this pull request Oct 19, 2024
11 tasks
@padix-key padix-key added the on hold Some reason blocks the further development label Oct 22, 2024
@codspeed-hq

codspeed-hq Bot commented Jul 20, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 4.4%

⚡ 1 improved benchmark
❌ 2 (👁 2) regressed benchmarks
✅ 100 untouched benchmarks
⏩ 14 skipped benchmarks1

Performance Changes

Benchmark BASE HEAD Efficiency
benchmark_match_kmer_selection[BucketKmerTable(10000)-None] 353.8 µs 320.7 µs +10.32%
👁 benchmark_match_kmer_selection[KmerTable-None] 246.3 µs 278.9 µs -11.67%
👁 benchmark_match[KmerTable-None] 292.1 µs 325.8 µs -10.34%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing padix-key:clepaps (82daff1) with main (b6127ed)

Open in CodSpeed

Footnotes

  1. 14 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@padix-key
padix-key marked this pull request as ready for review July 21, 2026 09:11
@padix-key padix-key removed the on hold Some reason blocks the further development label Jul 21, 2026
@padix-key
padix-key merged commit 2587935 into biotite-dev:main Jul 21, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant