fix: hide overlay completely when content loads (#160)#161
Merged
Lipo11 merged 1 commit intobirdwingo:mainfrom Jul 7, 2025
marceloams:160-loading-overlay-always-visible-on-transparent-images
Merged
fix: hide overlay completely when content loads (#160)#161Lipo11 merged 1 commit intobirdwingo:mainfrom marceloams:160-loading-overlay-always-visible-on-transparent-images
Lipo11 merged 1 commit intobirdwingo:mainfrom
marceloams:160-loading-overlay-always-visible-on-transparent-images
Conversation
Lipo11
requested changes
Jul 4, 2025
Contributor
Lipo11
left a comment
There was a problem hiding this comment.
hey! the next state is not necessary, i would use reanimated for this like:
const loading = useSharedValue(true);
const containerAnimatedStyle = useAnimatedStyle(() => ({
opacity: loading.value ? 1 : 0,
}));
return (
<Animated.View style={[ImageStyles.container, containerAnimatedStyle]}>
{/* ... */}
</Animated.View>
);
Contributor
Author
|
Hey @Lipo11 , you're right, thanks for the feedback! I'm not used to reanimated, this solution does the trick! I'll follow this and update the code. |
Lipo11
approved these changes
Jul 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes loading overlay showing behind transparent images by setting container opacity to 0 after content loads.
Closes #160