Skip to content

Disable forms when loading #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 23, 2025
Merged

Conversation

johnny9
Copy link
Contributor

@johnny9 johnny9 commented May 23, 2025

During loading, the Send and Receive forms are disabled and greyed out.

This includes the initialized property added to WalletQmlController just as in #455

Screenshot from 2025-05-23 00-40-10
Screenshot from 2025-05-23 00-39-56

@GBKS
Copy link
Contributor

GBKS commented May 23, 2025

Looking good. Small tweak would be to use Neutral 4 for the disabled text and lines. This PR seems to use Neutral 2, which is barely visible.

@johnny9
Copy link
Contributor Author

johnny9 commented May 23, 2025

Looking good. Small tweak would be to use Neutral 4 for the disabled text and lines. This PR seems to use Neutral 2, which is barely visible.

I'll change it to Neutral 4

@johnny9
Copy link
Contributor Author

johnny9 commented May 23, 2025

from e41eabf to 1ba83b4

  • Used neutral4 for thinner items (Text, separator lines, and small icons)

Screenshot from 2025-05-23 09-00-52
Screenshot from 2025-05-23 09-00-38

Copy link
Contributor

@MarnixCroes MarnixCroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 1ba83b4

@hebasto hebasto merged commit 1c7e20a into bitcoin-core:main May 23, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants