build: detect arm32 assembly by default #1752
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raimo33
force-pushed
the
detect-arm32-asm
branch
2 times, most recently
from
5de771e to
2b65c2d
Compare
Please provide benchmarks to support this statement. |
Raimo33
force-pushed
the
detect-arm32-asm
branch
from
2b65c2d to
d987270
Compare
Raimo33
force-pushed
the
detect-arm32-asm
branch
from
d987270 to
7a613ce
Compare
will do. I'm buying a raspberry PI right now. I reckon if the benchmarks don't show improvements we should delete |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #1751 by adding a call to
check_arm32_assembly()by default, matching the current behavior withcheck_x86_64_assembly().This would result in speedup on
field_10x26_impl.hon default builds. For example, currently, the Bitcoin Core reference implementation compiles libsecp256k1 with default options, leading to unoptimal builds.