sim-cli/refactor: do not call add_node_to_maps in validate_activities #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chuksys
force-pushed
the
activity-validation-params
branch
from
f9547e6 to
3aeccc7
Compare
|
Hi @f3r10 if you have the bandwidth, please can you review this little change in how arguments are passed into |
carlaKC
reviewed
Mar 28, 2025
chuksys
changed the title
chuksys
force-pushed
the
activity-validation-params
branch
from
3aeccc7 to
31eba78
Compare
|
You can go ahead and squash the fixups then we'll merge 👍 |
chuksys
force-pushed
the
activity-validation-params
branch
from
31eba78 to
a2705aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #237