Skip to content

Conversation

@jrakibi
Copy link
Contributor

@jrakibi jrakibi commented Sep 22, 2025

This PR implements threaded XML generation that preserves reply relationships (parent-child) in generated XML files

  • Supports both flat and threaded author formats
  • Support new threading fields from ElasticSearch: thread_depth, thread_position, reply_to_author, parent_id
  • This is still backward compatible with existing XML files (old strcuture)

PS: There are many debug logs in the code to help trace job actions in CI. These will be removed once all XML files are updated

@jrakibi
Copy link
Contributor Author

jrakibi commented Sep 22, 2025

Related PR: This PR works together with bitcoinsearch/scraper#100 and bitcoinsearch/tldr#526. All PRs should be merged for full threading functionality.

@jrakibi jrakibi force-pushed the 22-09-threading-replies branch from f91d1cd to 6d6bffe Compare September 26, 2025 17:08
@jrakibi
Copy link
Contributor Author

jrakibi commented Sep 26, 2025

Copy link

@satsie satsie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your log messages are so nice :)

While I can't really comment on the correctness of the code, I looked over it and it seems fine to me. I'm sorry I cannot review it for bugs.

I took a look at the preview link you provided and it looks great. I didn't think we'd be able to get this feature done so quickly so I appreciate the fast turnaround on something that was very non-trivial. Per the product call last Wednesday I think we still need to:

  • change the "Original Post" pill to be a light orange
  • expand the background color on mobile for threads with a ton of nested replies

Both those are front end things that I don't should be blockers to merging this. Approving!

@satsie
Copy link

satsie commented Oct 6, 2025

Ooooo I just noticed something. In the preview link you provided, I expanded all the replies and clicked the second to last one from Saint Wenhao. When I click "Link to Raw post" it takes me to the raw link for what I believe to be the whole thread, not Saint Wenaho's raw reply.

Not sure if that issue is related to this PR though.

@jrakibi
Copy link
Contributor Author

jrakibi commented Oct 7, 2025

when I click "Link to Raw post" it takes me to the raw link for what I believe to be the whole thread, not Saint Wenaho's raw reply.
Not sure if that issue is related to this PR though.

I think we had this issue before, you can see it from this thread in prod:
https://tldr.bitcoinsearch.xyz/summary/bitcoin-dev/Oct_2025/combined_On-in-ability-to-embed-data-into-Schnorr

It always takes you to the whole thread regardless of which reply you click.

Thanks for noticing that! I’ll open an issue for it so we can address it in a separate PR.

@jrakibi
Copy link
Contributor Author

jrakibi commented Oct 7, 2025

Per the product call last Wednesday I think we still need to:

Thanks, fixed here: bitcoinsearch/tldr#526 (comment)

Not sure if that issue is related to this PR though.

Opened a separate issue for it: bitcoinsearch/tldr#534

@jrakibi jrakibi merged commit d5428f9 into main Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants