Merged
Conversation
maltoe
force-pushed
the
fix/issue-121-handle-null-rows-in-records
branch
from
8c3e071 to
8283ae1
Compare
When the trigger query returns null, we currently fail with a rather
obscure
```
** (Postgrex.Error) ERROR 23502 (not_null_violation) null value in column "data" of relation "changes" violates not-null constraint
table: changes
column: data
```
That is because Postgres propagates the null value when the second
argument to the `- (jsonb, text[])` operator is null`.
```
-- returns null
select '{}'::jsonb - NULL;
```
This patch handles this case explicitly and raises a better error
message.
maltoe
force-pushed
the
fix/issue-121-handle-null-rows-in-records
branch
from
8283ae1 to
a5243b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the trigger query returns null, we currently fail with a rather obscure
That is because Postgres propagates the null value when the second argument to the
- (jsonb, text[])operator is null`.This patch handles this case explicitly and raises a better error message.
Fixes #121