Skip to content

Add test for alpine 3.20.2 with chrome 128#330

Open
andreasknoepfle wants to merge 1 commit intomainfrom
add-3-20-2-alpine-test
Open

Add test for alpine 3.20.2 with chrome 128#330
andreasknoepfle wants to merge 1 commit intomainfrom
add-3-20-2-alpine-test

Conversation

@andreasknoepfle
Copy link
Member

No description provided.

@@ -1,3 +1,3 @@
# locked to the versions we use in the lint CI job
elixir 1.14.5
erlang 25.3.1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version is not working properly on a Mac without a lot of hassle.

@andreasknoepfle andreasknoepfle force-pushed the add-3-20-2-alpine-test branch 3 times, most recently from c6c7632 to 8ab58e5 Compare September 26, 2024 12:09
strategy:
matrix:
dockerfile: ['elixir-1-11', 'debian-buster', 'alpine-3-17-3', 'alpine-3-18-4']
dockerfile: ['elixir-1-11', 'debian-buster', 'alpine-3-17-3', 'alpine-3-18-4', 'alpine-3-20-2']
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already ran it once on this branch :)

Copy link
Collaborator

@maltoe maltoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷 Looks good, but still fails on my machine (ie. I've built this locally and ran the tests)

@andreasknoepfle
Copy link
Member Author

🤷 Looks good, but still fails on my machine (ie. I've built this locally and ran the tests)

Can we try to reproduce this on a CI run somehow?

@maltoe
Copy link
Collaborator

maltoe commented Nov 17, 2024

🤷 Looks good, but still fails on my machine (ie. I've built this locally and ran the tests)

Can we try to reproduce this on a CI run somehow?

Not sure how, I mean we already run it inside this very container, on comparable x86-64 hardware on Linux. Maybe kernel version or some config issue? Not sure 🤷

Should we still merge this?

@maltoe
Copy link
Collaborator

maltoe commented Jan 19, 2026

@andreasknoepfle Chrome is at v143 already, should we update this PR and see if it works again? Then we could just warn about some incompatible versions in the README and be done with it.

@andreasknoepfle
Copy link
Member Author

sure. If I remember well you could get it to fail on your system, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants