Merged
Conversation
Closed
Member
andreasknoepfle
left a comment
andreasknoepfle
left a comment
There was a problem hiding this comment.
Can you also prepare an entry for the CHANGELOG.md? Like under [Unreleased]. You can check the history of the file to see how we normally do it.
andreasknoepfle
approved these changes
Mar 4, 2025
maltoe
reviewed
Mar 4, 2025
|
|
||
| describe "timezone can be set thru print_to_pdf/2" do | ||
| setup do | ||
| start_supervised!({ChromicPDF, offline: false}) |
Collaborator
There was a problem hiding this comment.
Is the offline: false necessary for this test?
Contributor
Author
There was a problem hiding this comment.
Sorry about that, @maltoe - it is not required. I've removed it!
Co-authored-by: Andreas Knöpfle <andreas.knoepfle@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #336
This PR adds a set_timezone option to the navigate protocol.