Skip to content

Add support for nimble_pool 1.1#342

Closed
aforward wants to merge 1 commit intobitcrowd:mainfrom
aforward:f/upgrade-nimble_pool
Closed

Add support for nimble_pool 1.1#342
aforward wants to merge 1 commit intobitcrowd:mainfrom
aforward:f/upgrade-nimble_pool

Conversation

@aforward
Copy link

@aforward aforward commented Jan 5, 2026

{:nimble_pool, "~> 0.2 or ~> 1.0 or ~> 1.1"},

This is because I ran into an issue trying to run chromic_pdf and finch, namley

Dependencies have diverged:
* nimble_pool (Hex package)
  the dependency nimble_pool 1.0.0

  > In deps/chromic_pdf/mix.exs:
    {:nimble_pool, "~> 0.2 or ~> 1.0", [env: :prod, hex: "nimble_pool", repo: "hexpm", optional: false]}

  does not match the requirement specified

  > In deps/finch/mix.exs:
    {:nimble_pool, "~> 1.1", [env: :prod, hex: "nimble_pool", repo: "hexpm", optional: false]}

  Ensure they match or specify one of the above in your deps and set "override: true"
** (Mix) Can't continue due to errors on dependencies

From the changlelog
https://github.com/dashbitco/nimble_pool/blob/main/CHANGELOG.md#v110-2024-03-25

Add handle_cancelled/2 pool callback

I don't see any issues with the upgrade

```elixir
{:nimble_pool, "~> 0.2 or ~> 1.0 or ~> 1.1"},
```

This is because I ran into an issue trying to run chromic_pdf and finch, namley

```
Dependencies have diverged:
* nimble_pool (Hex package)
  the dependency nimble_pool 1.0.0

  > In deps/chromic_pdf/mix.exs:
    {:nimble_pool, "~> 0.2 or ~> 1.0", [env: :prod, hex: "nimble_pool", repo: "hexpm", optional: false]}

  does not match the requirement specified

  > In deps/finch/mix.exs:
    {:nimble_pool, "~> 1.1", [env: :prod, hex: "nimble_pool", repo: "hexpm", optional: false]}

  Ensure they match or specify one of the above in your deps and set "override: true"
** (Mix) Can't continue due to errors on dependencies
```

From the changlelog
https://github.com/dashbitco/nimble_pool/blob/main/CHANGELOG.md#v110-2024-03-25

```
Add handle_cancelled/2 pool callback
```

I don't see any issues with the upgrade
@maltoe
Copy link
Collaborator

maltoe commented Jan 6, 2026

@aforward This is interesting... ~> 0.2 or ~> 1.0 is compatible with ~> 1.1, may I ask which version of Elixir you're using? Cannot reproduce this on 1.16, it installs nimblepool 1.1 just fine.

@aforward
Copy link
Author

aforward commented Jan 7, 2026

I am on elixir and 1.19 and OTP 28. I had tried unlocking the deps to start fresh but it still complained

$ elixir --version
Erlang/OTP 28 [erts-16.1.1] [source] [64-bit] [smp:12:12] [ds:12:12:10] [async-threads:1] [jit] [dtrace]

Elixir 1.19.1 (compiled with Erlang/OTP 28)
$ erl --version
Erlang/OTP 28 [erts-16.1.1] [source] [64-bit] [smp:12:12] [ds:12:12:10] [async-threads:1] [jit] [dtrace]

Eshell V16.1.1 (press Ctrl+G to abort, type help(). for help)

@maltoe
Copy link
Collaborator

maltoe commented Jan 8, 2026

@aforward Tried to reproduce it on Elixir 1.19.1, created a fresh app, added chromic_pdf 1.17 and finch 0.20 to the deps and mix deps.get resolves just fine. Can you produce a minimum working example of your issue?

@maltoe
Copy link
Collaborator

maltoe commented Jan 18, 2026

@aforward Please reopen when you can reproduce this. In any case, it's unlikely a ChromicPDF issue, and I'm hesitant to just merge it as a) it would needlessly force people on nimble_pool 1.0 to upgrade, and b) the version spec appears correct.

@maltoe maltoe closed this Jan 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants