Skip to content

Conversation

@nevlkv
Copy link

@nevlkv nevlkv commented Oct 10, 2025

I use dynamic url with multiple fqdn in the ingress

spec:
  ingressClassName: nginx
  rules:
  - host: keycloak.<subd1>.dev
    http:
      paths:
      - backend:
          service:
            name: keycloak
            port:
              name: http
        path: /
        pathType: ImplementationSpecific
  - host: keycloak.<subd2>.dev
    http:
      paths:
      - backend:
          service:
            name: keycloak
            port:
              name: http
        path: /
        pathType: ImplementationSpecific
  tls:

aka
image

Template force sets KC_HOSTNAME to defined first ingress.hostname but

Additionally if hostname is configured, then hostname-strict is ignored

image

I can set KC_HOSTNAME manual from ENV, from ingress or set undefined for dynamic

@github-actions github-actions bot added keycloak triage Triage is needed labels Oct 10, 2025
@github-actions github-actions bot requested a review from javsalgar October 10, 2025 13:17
@nevlkv nevlkv force-pushed the change_keycloak_hostname_settings branch from b09c344 to 98e8e5b Compare October 10, 2025 13:17
@carrodher
Copy link
Member

Thank you for initiating this pull request. We appreciate your effort. This is just a friendly reminder that signing your commits is important. Your signature certifies that you either authored the patch or have the necessary rights to contribute to the changes. You can find detailed information on how to do this in the “Sign your work” section of our contributing guidelines.

Feel free to reach out if you have any questions or need assistance with the signing process.

Signed-off-by: Nikolay Volkov <[email protected]>
@nevlkv nevlkv force-pushed the change_keycloak_hostname_settings branch from b8407f7 to cc77b90 Compare October 15, 2025 06:12
Signed-off-by: Bitnami Bot <[email protected]>
@nevlkv
Copy link
Author

nevlkv commented Oct 16, 2025

Thank you for initiating this pull request. We appreciate your effort. This is just a friendly reminder that signing your commits is important. Your signature certifies that you either authored the patch or have the necessary rights to contribute to the changes. You can find detailed information on how to do this in the “Sign your work” section of our contributing guidelines.

Feel free to reach out if you have any questions or need assistance with the signing process.

done )

@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Oct 16, 2025
@github-actions github-actions bot removed the triage Triage is needed label Oct 16, 2025
@github-actions github-actions bot removed the request for review from javsalgar October 16, 2025 12:43
@github-actions github-actions bot requested a review from jotamartos October 16, 2025 12:43
Signed-off-by: Bitnami Bot <[email protected]>
{{- if .Values.ingress.enabled }}
KC_HOSTNAME_STRICT: {{ ternary "true" "false" .Values.hostnameStrict | quote }}
{{- if .Values.ingress.hostname }}
{{- if and .Values.ingress.hostname (eq .Values.hostnameStrict true) }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the "eq true" condition is a bit redundant. Can you review this change?

Suggested change
{{- if and .Values.ingress.hostname (eq .Values.hostnameStrict true) }}
{{- if and .Values.ingress.hostname .Values.hostnameStrict }}

Copy link
Contributor

@jotamartos jotamartos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. Can you take a look at the requested changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in-progress keycloak verify Execute verification workflow for these changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants