-
Notifications
You must be signed in to change notification settings - Fork 10.3k
change hostname settings #36340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
change hostname settings #36340
Conversation
b09c344 to
98e8e5b
Compare
|
Thank you for initiating this pull request. We appreciate your effort. This is just a friendly reminder that signing your commits is important. Your signature certifies that you either authored the patch or have the necessary rights to contribute to the changes. You can find detailed information on how to do this in the “Sign your work” section of our contributing guidelines. Feel free to reach out if you have any questions or need assistance with the signing process. |
Signed-off-by: Nikolay Volkov <[email protected]>
b8407f7 to
cc77b90
Compare
Signed-off-by: Bitnami Bot <[email protected]>
done ) |
Signed-off-by: Bitnami Bot <[email protected]>
| {{- if .Values.ingress.enabled }} | ||
| KC_HOSTNAME_STRICT: {{ ternary "true" "false" .Values.hostnameStrict | quote }} | ||
| {{- if .Values.ingress.hostname }} | ||
| {{- if and .Values.ingress.hostname (eq .Values.hostnameStrict true) }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding the "eq true" condition is a bit redundant. Can you review this change?
| {{- if and .Values.ingress.hostname (eq .Values.hostnameStrict true) }} | |
| {{- if and .Values.ingress.hostname .Values.hostnameStrict }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution. Can you take a look at the requested changes?
I use dynamic url with multiple fqdn in the ingress
aka

Template force sets KC_HOSTNAME to defined first ingress.hostname but
Additionally if hostname is configured, then hostname-strict is ignored
I can set KC_HOSTNAME manual from ENV, from ingress or set undefined for dynamic