-
Notifications
You must be signed in to change notification settings - Fork 10.3k
[bitnami/keycloak] New param javaOptsAppendExtra to append additional java opts #36350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kongdewen
wants to merge
9
commits into
bitnami:main
Choose a base branch
from
kongdewen:new-param-javaOptsAppendExtra-for-keycloak-cache
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[bitnami/keycloak] New param javaOptsAppendExtra to append additional java opts #36350
kongdewen
wants to merge
9
commits into
bitnami:main
from
kongdewen:new-param-javaOptsAppendExtra-for-keycloak-cache
+18
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dewen Kong <[email protected]>
Signed-off-by: Dewen Kong <[email protected]>
Signed-off-by: Dewen Kong <[email protected]>
Signed-off-by: Dewen Kong <[email protected]>
ab0d042 to
45a6c23
Compare
Signed-off-by: Bitnami Bot <[email protected]>
Signed-off-by: Bitnami Bot <[email protected]>
Signed-off-by: Bitnami Bot <[email protected]>
gongomgra
requested changes
Oct 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! I have added a suggestion. Can you take a look at it?
Co-authored-by: Gonzalo Gómez Gracia <[email protected]> Signed-off-by: Dewen Kong <[email protected]>
Signed-off-by: Bitnami Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Currently we need to overwrite JAVA_OPTS_APPEND in the extraEnv section with jgroups.dns.query to add new JAVA_OPT_APPEND. Intro new param which is to append to JAVA_OPTS_APPEND
Benefits
A simple option to add additional parameters would allow for an easier configuration.
Possible drawbacks
N/A
Applicable issues
Has been raised previous in #31847, and #34813
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm