Skip to content

Conversation

fedemkr
Copy link
Member

@fedemkr fedemkr commented Jul 7, 2025

🎟️ Tracking

PM-25300

📔 Objective

Adds docs on Sourcery usage on automatic mock generation on iOS architecture.
This has been added in bitwarden/ios#1724.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@fedemkr fedemkr requested review from a team as code owners July 7, 2025 17:56
Copy link

cloudflare-workers-and-pages bot commented Jul 7, 2025

Deploying contributing-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: a292135
Status: ✅  Deploy successful!
Preview URL: https://c86d79d6.contributing-docs.pages.dev
Branch Preview URL: https://ios-pm-23500-sourcery-usage.contributing-docs.pages.dev

View logs

Copy link

github-actions bot commented Jul 7, 2025

Logo
Checkmarx One – Scan Summary & Detailsc658a82e-7423-4974-b20d-adc4d56466a9

Great job, no security vulnerabilities found in this Pull Request

djsmith85
djsmith85 previously approved these changes Jul 17, 2025
dasien
dasien previously approved these changes Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants