Skip to content

Move Check-Run to individual reusable workflow components#486

Draft
mandreko-bitwarden wants to merge 1 commit intomainfrom
check-run-move
Draft

Move Check-Run to individual reusable workflow components#486
mandreko-bitwarden wants to merge 1 commit intomainfrom
check-run-move

Conversation

@mandreko-bitwarden
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/VULN-325

📔 Objective

While discussing some of the Claude workflow changes here, we opted to make our re-usable workflow files more self-contained, handling their own dependencies of check-run.yml. This change is reflected here, by moving it out of the scan.yml, and into each subsequent scanner component workflow.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@github-actions
Copy link

Logo
Checkmarx One – Scan Summary & Details836029bb-f9af-4bf2-b4ca-8afedc43448a

Great job! No new security vulnerabilities introduced in this pull request

@github-actions
Copy link

Logo
Checkmarx One – Scan Summary & Details719532d0-834d-4320-9782-e4a601a36440

Great job! No new security vulnerabilities introduced in this pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant