PM-25012: Cipher versioning data types #433
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikwithak
changed the base branch from
main
to
vault/cipher-versioning-with-data
|
New Issues (4)Checkmarx found the following issues in this Pull Request
|
nikwithak
commented
Sep 12, 2025
| @@ -279,7 +279,7 @@ impl Decryptable<KeyIds, SymmetricKeyId, Fido2CredentialFullView> for Fido2Crede | |||
|
|
|||
| #[allow(missing_docs)] | |||
| #[derive(Serialize, Deserialize, Debug, Clone)] | |||
| #[serde(rename_all = "camelCase", deny_unknown_fields)] | |||
| #[serde(rename_all = "camelCase")] | |||
There was a problem hiding this comment.
Are there any concerns / issues with allowing (and ignoring) unknown fields during deserialization? Removing this attribute from all the CipherType types drastically simplifies the extraction process.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## vault/cipher-versioning-with-data #433 +/- ##
====================================================================
Coverage ? 74.78%
====================================================================
Files ? 256
Lines ? 22400
Branches ? 0
====================================================================
Hits ? 16752
Misses ? 5648
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nikwithak
changed the title
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-25012
📔 Objective
Moves the deserialization of the
dataobject into the SDK - as part of running cipher migrations, the CipherType objects will be extracted instead of being passed in from the client.⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes