-
Notifications
You must be signed in to change notification settings - Fork 17
[PM-20288] Automate iOS repo update and improve release-swift process #439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… We should format this file in sdk-internal instead.
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #439 +/- ##
=======================================
Coverage 76.93% 76.93%
=======================================
Files 270 270
Lines 25608 25608
=======================================
Hits 19702 19702
Misses 5906 5906 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
01fbd60
to
66c4b00
Compare
|
🎟️ Tracking
PM-20288
📔 Objective
The initial goal was to trigger an iOS repo SDK update when sdk-internal
main
is updated, implementing that led to hard to maintain duplicate steps that were also slowing down the whole process even further, ended up refactoring multiple bits that would be hard to review independently. My suggestion for reviewers is to go through it as a new file instead of change-by-change. With that, here's a summary of updates:Structural
persist-credentials: false
onaction/checkout
when we just need to checkout the repoFunctional
main
run-as
to communicate the Build we're releasing. [screenshot#3 - old vs new]Test Run:
[screenshot#1 - sdk-swift new commit message format]

[screenshot#2 - Action Summary]

[screenshot#3 - Action

run-as
]⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes