Update TinySTL (attempt 2).#341
Conversation
This reverts commit 73966ef.
|
There is issue with MSVC builds: |
|
Instead updating the whole thing, you should fix whatever you need to fix in bx. |
|
It's not an error. Was a type-cast warning elevated to error-level. Fixed in #342, checked the CI bots now for warnings. Good to know that's a thing. Real issue here is that bx is compiled with lower warning-to-error-escalation settings than bgfx. Therefore CI test on bx passed, but failed on bgfx. |
It shouldn't... Where is the difference? |
|
On the one hand (warning as error in bgfx): On the other hand (bx): https://github.com/bkaradzic/bx/actions/runs/12992772828/job/36233405585 Warnings not even printed, for a test Perhaps the bx test suite doesn't have the same warnings enabled? |
|
Found the issue... |
A better-tested updated version of TinySTL. Replaces #340.
This library was in a very buggy state, so I made my own fork of it, patched all the issues, and made a PR there (mendsley/tinystl#27).
I added some extra tests that were present in the tinystl repo, but not yet in the bx testsuite. All tests are passing. This time I did test the examples, and I don't get any crashes.
Also includes a small update-script to pull it the sources from the original repo and replace all
#include <TINYSTL/xxx>with#include <tinystl/xxx>usingsed.Idk if there are cool tricks in Github to rewrite git history as if my first PR was never merged (instead of merged, reverted, and then this merged).