Fix minor issues with Gowin vendor #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mitives up to now.
… (xdr==2). Thanks to tcjie/Gowin.
… oscillators. Fix comment style in generated cst and sdc files.
…n_command_templates to be a list instead of dict.
…Introduced subseries property to be able to specify in the board platform.
- add missing osc_freq property (used in default_clk_constraint when sys_clk0 is used) - compute --freq value for nextpnr-gowin instead of hardcoding 27 MHz - remove -v gowin_pack flag (gowin_pack doesn't have that flag)
whitequark
force-pushed
the
support-gw1n-9c
branch
2 times, most recently
from
512d8bf to
efc0860
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small PR on top of amaranth-lang#734 – I can confirm it works with my Tang Nano 1K (and will send a separate PR on top of amaranth-lang/amaranth-boards#208 once I clean it up). Thank you!
osc_freqproperty (used indefault_clk_constraintwhensys_clk0is used)--freqvalue fornextpnr-gowininstead of hardcoding 27 MHz-vgowin_packflag (gowin_packdoesn't have that flag)