Hide GetConn #278
Open
Hide GetConn #278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping. I have a patch that makes get_conn a plain async fn, but it depends on this. |
|
ping. I have rebased it on top of current master. |
|
In case you find it easier to review it all at once, #285 has both this patch and the conversion to a plain async fn. |
|
I have rebased it once more. |
This makes the future implementation private. This is a braking change, but: * It is unlikely anyone was using GetConn directly instead of just awaiting it. * This opens the way for replacing the manual implementation with an async fn.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the future implementation private. This is a braking change, but:
It is unlikely anyone was using GetConn directly instead of just awaiting it.
This opens the way for replacing the manual implementation with an async fn.