-
Notifications
You must be signed in to change notification settings - Fork 5
Working skeleton for parameterized test framework #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
shantyk
wants to merge
22
commits into
master
Choose a base branch
from
dev/shanty/testing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c86d09a
to
9d42be9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A test framework proposal for NuGet Inspector because
There is plenty of room for improvement here. Because the tests are not dockerized and expect the machine that is running them to be set up a certain way, we will need to make sure the build machine for our pipelines is and stays configured in a certain way. Good thing is, our Jenkins machine already IS configured with multiple versions of dotnet and newer versions have been added. This does make running them locally difficult. But maybe worth it if it means usually we run these tests only in Jenkins anyway?
Essentially:
-> Set up environment with appropriate version of dotnet.
-> Create test solution, add projects, add dependencies all with that dotnet version.
-> run dotnet list/restore as source of truth.
--> manipulate solution directory as needed to trigger different cascade branches.
Pros:
(ran dotnet test --collect:"XPlat Code Coverage" and got coverage line-rate="0.44920000000000004" branch-rate="0.3803" version="1.9" timestamp="1759933557" lines-covered="1076" lines-valid="2395" branches-covered="286" branches-valid="752" for this branch. For master the output is: coverage line-rate="0.1133" branch-rate="0.1103" version="1.9" timestamp="1759933682" lines-covered="271" lines-valid="2391" branches-covered="83" branches-valid="752")
Cons:
Closes IDETECT-4830, 4827, 4826