Can we please merge latest from ESP32-BLE-Keyboard #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes to media keys connect and disconnect.
Allow for additional services like logging
Set ScanResponse to off so the advertising will actually advertise...
… a stored preference etc. added setName function to allow changing the name of the device using a stored preference etc. Must be called before begin().
added setName function to allow changing the name of the device using a stored preference (must be called before begin).
removed xTaskCreate in begin() removed BleConnectionStatus removed KeyboardOutputCallbacks implemented callbacks directly in BleKeyboard
Added Numpad key definitions, also PRTSC was missing. Added version information, including MAJOR, MINOR and PATCH.
Numpad Key definitions, PRTSC and version info
Update readme to reflect commenting out CTRL+ALT+DEL code.
Comment out CTRL+ALT+DEL code
Remove Ctrl+Alt+Del from README example
Comment out CTRL+ALT+DEL
Fixed MediaKeys releasing on ReleaseAll
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems to be quite out of sync now, is there a plan to merge?