fix: use JSON.stringify/parse to clone queries (#40)

blackmann · Dec 27, 2023 · 9604b9b · 9604b9b
1 parent f9f04fd
commit 9604b9b
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/base/src/lib/clone.ts b/base/src/lib/clone.ts
@@ -0,0 +1,5 @@
+function clone<T>(obj: T) {
+  return JSON.parse(JSON.stringify(obj)) as T
+}
+
+export { clone }
diff --git a/base/src/schema.test.ts b/base/src/schema.test.ts
@@ -861,9 +861,7 @@ describe('schema', () => {
       expect(
         schema.castQuery({ createdAt: { $gte: undefined } })
       ).toStrictEqual({
-        createdAt: {
-          $gte: undefined,
-        },
+        createdAt: {},
       })
 
       expect(schema.castQuery({ createdAt: { $gte: true } })).toStrictEqual({

diff --git a/base/src/schema.ts b/base/src/schema.ts
@@ -1,3 +1,5 @@
+import { clone } from './lib/clone.js'
+
 const types = [
   'any',
   'array',
@@ -157,7 +159,7 @@ class Schema {
    * With this knowledge, only nested query operators (eg. $in) are also considered.
    */
   castQuery(query: Record<string, any>) {
-    const res = structuredClone(query)
+    const res = clone(query)
 
     for (const [key, value] of Object.entries(res)) {
       const definition = this.getDefinitionAtPath(key)
@@ -259,7 +261,7 @@ class Schema {
       throw new Error('`data` is undefined')
     }
 
-    const res = structuredClone(data)
+    const res = clone(data)
 
     for (const [key, definition] of Object.entries(this.schema)) {
       const value = res[key]