Allow prereleases to contain x #76
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielhelfand
commented
Nov 30, 2021
Comment on lines
+331
to
+334
| opStr, vStr, err := splitComparatorVersion(ap) | ||
| if err != nil { | ||
| return nil, err | ||
| } |
There was a problem hiding this comment.
This was moved up to not break the following expandedWildcardVersions test case: {[][]string{{"foox"}}, nil}.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #75
This pull request slightly alters
expandWildcardVersionsto usestrings.Contains(.x)instead ofstrings.Contains(x)for trying to assess whether a range condition has a wildcard. This allows prereleases withxin the name as opposed to failing with the error documented in #75:Could not get version from string: "<".