Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: move where datastore queries get built. #162

Draft
wants to merge 1 commit into
base: myron/improve-perf/refactor-query-adapter-dependencies
Choose a base branch
from
Draft

Refactor: move where datastore queries get built. #162

wants to merge 1 commit into from

Conversation

myronmarston
Copy link
Collaborator

Rather than building them in GraphQLAdapter when a resolver yields, build them in the resolver that need it.

This paves the way for a larger refactoring I'm working on.

@myronmarston
Refactor: move where datastore queries get built.
faa4890 
Rather than building them in `GraphQLAdapter` when a resolver yields,
build them in the resolver that need it.

This paves the way for a larger refactoring I'm working on.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrianSigafoos-SQ BrianSigafoos-SQ Awaiting requested review from BrianSigafoos-SQ BrianSigafoos-SQ will be requested when the pull request is marked ready for review BrianSigafoos-SQ is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@myronmarston @CLAassistant