Refactor: move where we call field.coerce_result
.
#166
+14
−29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we called it from
GarphQLAdapter#call
, applying it to all resolved fields. However, we only need to use it in the aggregationGroupedBy
resolver, where we getDayOfWeek
enum values that we may need to coerce. There are no other cases where it is needed.This allows us to simplify
GarphQLAdapter#call
so that it now only does two things:This will allow us to further optimize by leveraging built-in functionality of the GraphQL gem to have it dispatch to the appropriate resolver in a more performant manner.