Use new resolver metadata for Document and Hash resolvers.
#173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, it handled both the `Hash` and `Document` cases, via a `case` statement on `object`. Instead, we can handle it with two separate resolvers. The `Document` resolver simply delegates to the `Hash` resolver after extracting the hash `payload`. We want to minimize the logic that needs to happen to resolve each field, so it's nice to eliminate this `case` statement.
This allows us to set runtime metadata overrides in multiple spots and trust that the merged result will be used.
This moves us one step closer to being able to use the GraphQL gem's native resolver disaptching.
|
|
myronmarston
force-pushed
the
myron/improve-perf/runtime-metadata-overrides
branch
from
0425911 to
4aba247
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves us one step closer to being able to use the GraphQL gem's native resolver disaptching.