Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework how Query type is defined and customized. #175

Draft
wants to merge 1 commit into
base: myron/improve-perf/migrate-get-record-field-value
Choose a base branch
from

Conversation

myronmarston
Copy link
Collaborator

Previously, it was defined in GraphQLSDLEnumerator and required an extension to customize it. Defining it in GraphQLSDLEnumerator meant that it was only included in the schema.graphql artifact and was not available to dump in runtime_metadata.yaml. We need to be able to dump resolver runtime metadata for the Query type, and this enables that. Customization can be done via on_built_in_types.

Previously, it was defined in `GraphQLSDLEnumerator` and required an extension
to customize it. Defining it in `GraphQLSDLEnumerator` meant that it was only
included in the `schema.graphql` artifact and was not available to dump in
`runtime_metadata.yaml`. We need to be able to dump `resolver` runtime metadata
for the `Query` type, and this enables that. Customization can be done via
`on_built_in_types`.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants