feat: allow for multiple values in cli options for adding extensions #1070
+35
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalvinnchau
approved these changes
Feb 5, 2025
| extension: Option<String>, | ||
| builtin: Option<String>, | ||
| extensions: Vec<String>, | ||
| builtin: Vec<String>, |
There was a problem hiding this comment.
nit: lets name this builtins to be consistent with extensions
wendytang
approved these changes
Feb 5, 2025
|
@kalvinnchau just tried it, and it works with both appraches |
|
@angiejones made some documentation updates. feel free to adjust |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, you can only specify one extension on the cli through each of the
--with-builtinand--with-extensionoptions:goose session --with-extension "npx -y @modelcontextprotocol/server-memory" --with-builtin "developer". This PR extends the cli to allow for multiple values to be specified for each of these options:goose session --with-builtin developer,memory --with-extension "npx -y @modelcontextprotocol/server-memory" --with-extension "npx -y @modelcontextprotocol/server-github"This enables running goose in "headless" mode without modifying configurations and adding extensions on the fly