Fix certificate issue for internal company setup #1088
+29
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes block#1086 Add logic to handle custom certificates for internal company setup. * **crates/goose/src/providers/openai.rs** - Import `Certificate` from `reqwest` and `fs` module. - Add logic to load custom certificate from a specified path. - Update `Client::builder()` to include custom certificate configuration if specified. - Add `OPENAI_CERT_PATH` to the list of configuration keys. * **ui/desktop/src/config.ts** - Import `Certificate` from `electron` and `fs` module. - Add `loadCustomCertificate` function to load custom certificate from a specified path. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/block/goose/issues/1086?shareId=XXXX-XXXX-XXXX-XXXX).
| @@ -8,3 +11,14 @@ export const getApiUrl = (endpoint: string): string => { | |||
| export const getSecretKey = (): string => { | |||
| return window.appConfig.get('secretKey'); | |||
| }; | |||
|
|
|||
| // Function to load custom certificate | |||
| export const loadCustomCertificate = (certPath: string): Certificate | null => { | |||
There was a problem hiding this comment.
do we use it somewhere?
| let mut client_builder = Client::builder().timeout(Duration::from_secs(600)); | ||
|
|
||
| if let Some(cert_path) = cert_path { | ||
| let cert = fs::read(cert_path)?; |
There was a problem hiding this comment.
better naming? like cert_data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1086
Add logic to handle custom certificates for internal company setup.
crates/goose/src/providers/openai.rs
Certificatefromreqwestandfsmodule.Client::builder()to include custom certificate configuration if specified.OPENAI_CERT_PATHto the list of configuration keys.ui/desktop/src/config.ts
Certificatefromelectronandfsmodule.loadCustomCertificatefunction to load custom certificate from a specified path.For more details, open the Copilot Workspace session.