Fix background process termination on stop button #1090
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes block#1062 Add logic to terminate background processes when the stop button is clicked. * **ui/desktop/src/ChatWindow.tsx** - Add logic to terminate background processes in the `onStopGoose` function. - Update the `stop` function to include background process termination. * **ui/desktop/src/ai-sdk-fork/call-custom-chat-api.ts** - Add a `stop` function to terminate background processes. * **ui/desktop/src/main.ts** - Update the `stop-power-save-blocker` function to stop background processes. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/block/goose/issues/1062?shareId=XXXX-XXXX-XXXX-XXXX).
alexhancock
reviewed
Feb 5, 2025
| @@ -90,3 +90,12 @@ export async function callCustomChatApi({ | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| export function stop() { | |||
| @@ -189,6 +189,9 @@ export function ChatContent({ | |||
| const updatedMessages = [...messages.slice(0, -1), newLastMessage]; | |||
| setMessages(updatedMessages); | |||
| } | |||
|
|
|||
| // Terminate any background processes | |||
| window.electron.terminateBackgroundProcesses(); | |||
There was a problem hiding this comment.
This doesn't seem to be defined
|
The frontend is already aborting the request properly. The agent side needs to reap the child processes when the connection is cut off goose/crates/goose-server/src/routes/reply.rs Lines 344 to 346 in 1c9a7c0 Will look into why this was disabled |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1062
Add logic to terminate background processes when the stop button is clicked.
ui/desktop/src/ChatWindow.tsx
onStopGoosefunction.stopfunction to include background process termination.ui/desktop/src/ai-sdk-fork/call-custom-chat-api.ts
stopfunction to terminate background processes.ui/desktop/src/main.ts
stop-power-save-blockerfunction to stop background processes.For more details, open the Copilot Workspace session.