feat: Add retry on rate limit errors #1095
Open
+43
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #1008 I was using an AWS account with a lower request limit, and I was getting throttling exceptions frequently similar to what's reported on #887. This PR adds a new environment variable
GOOSE_AGENT_RETRY_MULTIPLIER_MS
to enable retries onProviderError::RateLimitExceeded
errors fromProvider
s inTruncateAgent
. It uses a very simple retry with exponential backoff.For example, I tried to add a
MetricAgent
to goose, and after some iterations I got a rate limit error:then I enabled retry by changing my config:
and this time after rate limits, goose agent retries the request and got success on the second retry:
Of course if the limit is too low it will probably do lots of unsuccessful retries, but I feel like this could be helpful in some cases.