Fix MCP timeouts to be recoverable #1100
Open
+90
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes block#1075 Add timeout and cancellation handling for long running commands in Goose MCP. * Modify `crates/goose-cli/src/commands/session.rs` to add a timeout mechanism using `tokio::time::timeout` in the `agent_process_messages` function and implement cancellation notifications to interrupt long running commands. * Add a `cancel` method to `McpService` in `crates/mcp-client/src/service.rs` to send cancellation notifications. * Modify `crates/goose-cli/src/commands/mcp.rs` to add logic to handle cancellation notifications and interrupt long running commands in the `run_server` function. * Modify `crates/goose-server/src/commands/mcp.rs` to add logic to handle cancellation notifications and interrupt long running commands in the `run` function. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/block/goose/issues/1075?shareId=XXXX-XXXX-XXXX-XXXX).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1075
Add timeout and cancellation handling for long running commands in Goose MCP.
crates/goose-cli/src/commands/session.rsto add a timeout mechanism usingtokio::time::timeoutin theagent_process_messagesfunction and implement cancellation notifications to interrupt long running commands.cancelmethod toMcpServiceincrates/mcp-client/src/service.rsto send cancellation notifications.crates/goose-cli/src/commands/mcp.rsto add logic to handle cancellation notifications and interrupt long running commands in therun_serverfunction.crates/goose-server/src/commands/mcp.rsto add logic to handle cancellation notifications and interrupt long running commands in therunfunction.For more details, open the Copilot Workspace session.