WIP make snapshot default mode #5517

morgando · 2025-10-23T19:36:10Z

No description provided.

roborivers

Coding style check: Success ✓.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: 14/19 tests failed ⚠.

The first 10 failing tests are:
sc_force
socksql_master_swings

roborivers

Coding style check: Success ✓.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
comdb2sys_queueodh_generated
socksql
tunables
reco-ddlk-sql

roborivers

Coding style check: Success ✓.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
disttxn [core dumped]
analyze_fastinit_race
sc_force
socksql_master_swings
systable_locking
sc_resume_logicalsc_generated
sc_resume
queuedb_rollover_noroll1_generated
queuedb_rollover
sc_versmismatch_logicalsc_generated

morgando · 2025-10-24T22:27:13Z

tests/recover_deadlock.test/lrl.options

@@ -0,0 +1 @@
+sql_tranlevel_default blocksock


This test tests that a bunch of selects that run during schema changes succeed because they go through the recover ddlk process correctly. This is not relevant for snapshot since these selects will fail.

roborivers

Coding style check: Success ✓.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: 526/627 tests failed ⚠.

The first 10 failing tests are:
disttxn [core dumped]
analyze_fastinit_race
sc_resume_logicalsc_generated
sc_resume
queuedb_rollover_noroll1_generated
queuedb_rollover
sc_versmismatch
sc_versmismatch_logicalsc_generated
recover_deadlock
prepare

roborivers

Coding style check: Success ✓.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: 439/627 tests failed ⚠.

The first 10 failing tests are:
disttxn [core dumped]
tmptbl_leak [core dumped]
analyze_fastinit_race
sc_resume_logicalsc_generated
sc_resume
queuedb_rollover_noroll1_generated
queuedb_rollover
prepare
selectv_rcode_serialize_reads_like_writes_generated
udf

roborivers

Coding style check: Success ✓.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
disttxn [core dumped]
tmptbl_leak_starve_generated [core dumped]
tmptbl_leak [core dumped]
analyze_fastinit_race
sc_resume_logicalsc_generated
sc_resume
prepare
selectv_rcode_serialretry_generated
selectv_rcode_disable_svonly_nop_generated
udf

roborivers

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 145/200 tests failed ⚠.

The first 10 failing tests are:
cldeadlock [setup failure]
disttxn [core dumped]
newsqlreplay
random_osql_replay
sc_lotsoftables
pg_free_recovery
dohsql_race
insert_lots
insert_lots_ssl_generated
epochms_rollover

roborivers

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
cldeadlock [setup failure]
disttxn [core dumped]
newsqlreplay
random_osql_replay
dohsql_race
queuedb_rollover_noroll1_generated
pg_free_recovery
sc_drop
queuedb_rollover
insert_lots

roborivers

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: 71/630 tests failed ⚠.

The first 10 failing tests are:
ssl_san [setup failure]
disttxn [core dumped]
tmptbl_leak_starve_generated [core dumped]
tmptbl_leak [core dumped]
logdelete [core dumped]
schemalk_logicalsc_generated
schemalk_extralock_generated
schemalk
remotecreate_twopc_generated
remotecreate

morgando · 2025-10-30T21:01:30Z

tests/fingerprints.test/t02.req.out

@@ -1,7 +1,9 @@
 (version='1')


dont understand this test

morgando · 2025-10-30T21:08:56Z

tests/union_parallel.test/9_2_params.req.exp

@@ -1,3 +1,3 @@
-(c1='one', comdb2_ctxinfo ( 'parallel' )=1, a=1)


don't understand this test

roborivers

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 50/630 tests failed ⚠.

The first 10 failing tests are:
disttxn [core dumped]
tmptbl_leak [core dumped]
logdelete [core dumped]
logfill
analyze_fastinit_race
remotecreate_twopc_generated
remotecreate
phys_rep_tiered_firstfile_generated
sc_resume_logicalsc_generated
sc_resume

roborivers

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: 56/630 tests failed ⚠.

The first 10 failing tests are:
disttxn [core dumped]
tmptbl_leak_starve_generated [core dumped]
tmptbl_leak [core dumped]
logdelete [core dumped]
remotecreate_twopc_generated [core dumped]
analyze_fastinit_race
schemalk_logicalsc_generated
schemalk_extralock_generated
remotecreate
sc_resume_logicalsc_generated

morgando · 2025-11-10T23:14:52Z

sql.test just needs default consumer fix from #5548

roborivers

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: 56/633 tests failed ⚠.

The first 10 failing tests are:
electbug2 [setup core dumped]
disttxn [core dumped]
logdelete_snapshot_generated [core dumped]
logdelete [core dumped]
insert_lots
analyze_fastinit_race
fdb_compat_rte_connect_generated
remotecreate_twopc_generated
remotecreate
sc_resume_logicalsc_generated

roborivers

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 54/633 tests failed ⚠.

The first 10 failing tests are:
electbug2 [setup core dumped]
disttxn [core dumped]
tmptbl_leak [core dumped]
logdelete_snapshot_generated [core dumped]
logdelete [core dumped]
systable_locking
sc_truncate_lockorder_generated
schemalk_logicalsc_generated
schemalk_extralock_generated
schemalk

morgando · 2025-11-13T21:55:05Z

tests/consumer.test/t07.expected

 (old='{"a":"nan"}', new=NULL)
 (old='{"a":"-inf"}', new=NULL)
 (old='{"a":"inf"}', new=NULL)
-(old='{"a":1}', new=NULL)


It appears like the deletes process the rows in a different order in blocksql vs in recom+ :o

morgando · 2025-11-13T21:56:00Z

tests/fingerprints.test/t03.req.out

 (fingerprint='b12bfa0963ad238396f59e2e1e96b218', count=1, total_cost=12, total_rows=1, normalized_sql='SELECT count(*)FROM fp1;')
 (fingerprint='b16c596087126535ffc0e991e3477d8a', count=1, total_cost=0, total_rows=1, normalized_sql='SELECT?AS xyz;')
-(fingerprint='c7f22188d3a63015bac874fd692fd350', count=1, total_cost=12, total_rows=2, normalized_sql='SELECT x AS w FROM fp1 ORDER BY x;')
-(fingerprint='cb377fe3503a8413402ff6fdbf8d9f11', count=1, total_cost=12, total_rows=2, normalized_sql='SELECT x+x AS y FROM fp1 ORDER BY x;')


rows increase here because the txn can see its own updates.

roborivers

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 47/633 tests failed ⚠.

The first 10 failing tests are:
electbug2 [setup core dumped]
disttxn [core dumped]
cldeadlock [core dumped]
tmptbl_leak_starve_generated [core dumped]
tmptbl_leak [core dumped]
logdelete_snapshot_generated [core dumped]
logdelete [core dumped]
systable_locking
analyze_fastinit_race
sc_truncate_lockorder_generated

roborivers

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
disttxn [core dumped]
tmptbl_leak [core dumped]
logdelete_snapshot_generated [core dumped]
logdelete [core dumped]
remotecreate_twopc_generated [core dumped]
remotecreate [core dumped]
insert_lots
schemalk_logicalsc_generated
schemalk_extralock_generated
schemalk

Signed-off-by: mdouglas47 <[email protected]>

roborivers

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
electbug2 [setup core dumped]
disttxn [core dumped]
tmptbl_leak [core dumped]
logdelete_snapshot_generated [core dumped]
logdelete [core dumped]
remotecreate [core dumped]
schemalk_logicalsc_generated
schemalk_extralock_generated
remotecreate_twopc_generated
sc_resume_logicalsc_generated

morgando force-pushed the modsnap_default branch 2 times, most recently from 053ccf8 to edb4d40 Compare October 23, 2025 19:56

roborivers suggested changes Oct 23, 2025

View reviewed changes

morgando force-pushed the modsnap_default branch from edb4d40 to baa1e5b Compare October 24, 2025 14:35

roborivers suggested changes Oct 24, 2025

View reviewed changes

morgando force-pushed the modsnap_default branch 4 times, most recently from d4611da to db54e9b Compare October 24, 2025 22:26

morgando commented Oct 24, 2025

View reviewed changes

roborivers suggested changes Oct 25, 2025

View reviewed changes

roborivers suggested changes Oct 27, 2025

View reviewed changes

morgando force-pushed the modsnap_default branch 3 times, most recently from a58b9eb to ebb9048 Compare October 27, 2025 22:09

roborivers suggested changes Oct 28, 2025

View reviewed changes

roborivers approved these changes Oct 28, 2025

View reviewed changes

morgando force-pushed the modsnap_default branch from a84b910 to 8781019 Compare October 29, 2025 22:17

roborivers suggested changes Oct 30, 2025

View reviewed changes

morgando commented Oct 30, 2025

View reviewed changes

tests/fingerprints.test/t02.req.out

@@ -1,7 +1,9 @@

(version='1')

Copy link

Contributor Author

morgando Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont understand this test

morgando commented Oct 30, 2025

View reviewed changes

morgando force-pushed the modsnap_default branch 2 times, most recently from 5278b89 to 23b5ad2 Compare October 30, 2025 21:15

roborivers suggested changes Oct 31, 2025

View reviewed changes

morgando force-pushed the modsnap_default branch 4 times, most recently from 556f04d to 5909dd4 Compare November 4, 2025 15:49

morgando force-pushed the modsnap_default branch 6 times, most recently from 09aa31b to 86c9703 Compare November 4, 2025 23:05

roborivers suggested changes Nov 5, 2025

View reviewed changes

morgando force-pushed the modsnap_default branch from 86c9703 to ef41a88 Compare November 10, 2025 23:13

roborivers suggested changes Nov 11, 2025

View reviewed changes

morgando force-pushed the modsnap_default branch 2 times, most recently from a65d8fb to 9bec827 Compare November 11, 2025 22:39

roborivers suggested changes Nov 12, 2025

View reviewed changes

morgando force-pushed the modsnap_default branch 3 times, most recently from c3ff9b7 to 55eac0d Compare November 13, 2025 21:51

morgando commented Nov 13, 2025

View reviewed changes

roborivers suggested changes Nov 14, 2025

View reviewed changes

morgando force-pushed the modsnap_default branch from 55eac0d to 07cb419 Compare November 18, 2025 17:24

roborivers approved these changes Nov 18, 2025

View reviewed changes

Bug Fix: Clear snapshot state in sqlite_done

413ab0a

Signed-off-by: mdouglas47 <[email protected]>

morgando force-pushed the modsnap_default branch from 07cb419 to 65c5133 Compare November 21, 2025 22:00

morgando added 4 commits November 21, 2025 22:31

Update tests for blocksql->snapshot migration

12b0f71

Signed-off-by: mdouglas47 <[email protected]>

Don't stop RR after 10 fails

6881a0a

Signed-off-by: mdouglas47 <[email protected]>

Run tests with snapshot as default

62e60df

Signed-off-by: mdouglas47 <[email protected]>

Verify error

0027dfd

Signed-off-by: mdouglas47 <[email protected]>

morgando force-pushed the modsnap_default branch from 65c5133 to 0027dfd Compare November 21, 2025 22:31

roborivers approved these changes Nov 22, 2025

View reviewed changes

		@@ -1,3 +1,3 @@
		(c1='one', comdb2_ctxinfo ( 'parallel' )=1, a=1)

WIP make snapshot default mode #5517

Are you sure you want to change the base?

WIP make snapshot default mode #5517

Uh oh!

Conversation

morgando commented Oct 23, 2025

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

morgando Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

morgando Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

morgando Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

morgando commented Nov 10, 2025

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

morgando Nov 13, 2025

Choose a reason for hiding this comment

Uh oh!

morgando Nov 13, 2025

Choose a reason for hiding this comment

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants