Port remove hndl->cluster, check for default, don't ask sockpool for … #5554
Conversation
| static inline void only_read_config(cdb2_hndl_tp *hndl, int *default_err) | ||
| { | ||
| read_available_comdb2db_configs(NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL); | ||
| if (default_err && strcasecmp(hndl->type, "default") == 0) { |
There was a problem hiding this comment.
Added that we only do this check if default_err is defined
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
analyze
analyze_partial_index_off_generated
api_events
sc_transactional_rowlocks_generated
insert_lots_ssl_generated
insert_lots
reco-ddlk-sql
|
cdb2test Nov 7 00:22:07 2025 success nomodefault.R20251106.13 |
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
chands10
force-pushed
the
nomodefault
branch
from
cea6ba3 to
1804a81
Compare
…default Signed-off-by: Salil Chandra <[email protected]>
Signed-off-by: Salil Chandra <[email protected]>
chands10
force-pushed
the
nomodefault
branch
from
1804a81 to
e0fecbb
Compare
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
logfill_logput_window_generated
consumer_non_atomic_default_consumer_generated
truncatesc_offline_generated
insert_lots
reco-ddlk-sql
3 participants
/plugin-branch nomodefault