Call populate_modsnap_state before grabbing table locks #5579
Conversation
| (populate_modsnap_state(clnt) != 0)) { | ||
| rc = SQLITE_INTERNAL; | ||
| goto done; | ||
| } |
There was a problem hiding this comment.
Issue was that we already hold table locks at this point, and populate_modsnap_state then tried to grab the schema lock
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
sc_race_timepart [setup core dumped]
logfill_logput_window_generated
sc_resume
analyze_partial_index_off_generated
consumer_non_atomic_default_consumer_generated
insert_lots_ssl_generated
insert_lots
reco-ddlk-sql
|
|
morgando
force-pushed
the
snapshot_ddlk
branch
7 times, most recently
from
77ff774 to
736874e
Compare
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.
The first 10 failing tests are:
analyze
consumer_non_atomic_default_consumer_generated
tunables
si_sc_race
insert_lots_ssl_generated
insert_lots
reco-ddlk-sql
morgando
force-pushed
the
snapshot_ddlk
branch
from
736874e to
02c581c
Compare
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
morgando
force-pushed
the
snapshot_ddlk
branch
from
02c581c to
06864f0
Compare
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
sc_partial_datacopy_logicalsc_generated
incoherent_startup
consumer_non_atomic_default_consumer_generated
sc_transactional_rowlocks_generated
truncatesc_offline_generated
insert_lots_ssl_generated
insert_lots
reco-ddlk-sql
|
|
Signed-off-by: mdouglas47 <[email protected]>
morgando
force-pushed
the
snapshot_ddlk
branch
from
06864f0 to
e22b2c5
Compare
3 participants
Fixes a deadlock where replication holds the schema lock but waits on a table lock, while snapshot SQL holds the table lock and waits on the schema lock. The solution is to populate the snapshot’s state before acquiring table locks.