CBOR: parse safe uint64 as number (#3481)

* parse safe uint64 as number * rename test
bluesky-social · Jan 31, 2025 · 52c687a · 52c687a
1 parent 7f52e67
commit 52c687a
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 1 deletion.
diff --git a/.changeset/three-papayas-begin.md b/.changeset/three-papayas-begin.md
@@ -0,0 +1,5 @@
+---
+"@atproto/common": patch
+---
+
+Parse safe uint64 as number
diff --git a/packages/common/src/ipld-multi.ts b/packages/common/src/ipld-multi.ts
@@ -18,9 +18,15 @@ cborx.addExtension({
   },
 })
 
+const decoder = new cborx.Decoder({
+  // @ts-ignore
+  int64AsNumber: true, // not in types for some reason
+  useRecords: false,
+})
+
 export const cborDecodeMulti = (encoded: Uint8Array): unknown[] => {
   const decoded: unknown[] = []
-  cborx.decodeMultiple(encoded, (value) => {
+  decoder.decodeMultiple(encoded, (value) => {
     decoded.push(value)
   })
   return decoded

diff --git a/packages/common/tests/ipld-multi.test.ts b/packages/common/tests/ipld-multi.test.ts
@@ -22,4 +22,13 @@ describe('ipld decode multi', () => {
     expect(decoded[0]).toEqual(one)
     expect(decoded[1]).toEqual(two)
   })
+
+  it('parses safe ints as number', async () => {
+    const one = {
+      test: Number.MAX_SAFE_INTEGER,
+    }
+    const encoded = cborEncode(one)
+    const decoded = cborDecodeMulti(encoded)
+    expect(Number.isInteger(decoded[0]?.['test'])).toBe(true)
+  })
 })