Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use ubuntu 22.04 on github actions #3377

Merged
merged 1 commit into from
Jan 16, 2025
Merged

use ubuntu 22.04 on github actions #3377

merged 1 commit into from
Jan 16, 2025

Conversation

rafaelbsky
Copy link
Contributor

@rafaelbsky rafaelbsky commented Jan 16, 2025 •
edited
Loading

ubuntu-latest used to mean ubuntu-22.04 but around yesterday it was changed to mean ubuntu-24.04, which is breaking our builds because of something related to puppeteer

This changes it to explicitly rely on ubuntu-22.04 until we can make our setup work on ubuntu-24.04.

Relevant links:

@rafaelbsky rafaelbsky mentioned this pull request Jan 16, 2025
Merged
devinivy
devinivy approved these changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@devinivy devinivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rafaelbsky rafaelbsky merged commit 4e43cc0 into main Jan 16, 2025
10 checks passed
@rafaelbsky rafaelbsky deleted the use-ubuntu-22 branch January 16, 2025 18:46
@matthieusieben matthieusieben mentioned this pull request Jan 17, 2025
Open
@matthieusieben
Copy link
Contributor

Crated follow-up issue: #3382

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devinivy devinivy devinivy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rafaelbsky @matthieusieben @devinivy