Clear DID cache entry on PDS after identity.updateHandle #3393
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
char
changed the title
char
force-pushed
the
char/update-handle-bust-cache
branch
from
439062c to
9b51a5c
Compare
On a self-hosted PDS, updating an account's handle via `com.atproto.identity.updateHandle` won't change the reported `handle` value in `com.atproto.repo.describeRepo`, since the did cache still has stale data. To solve this, we just clear the cache after the updateHandle endpoint gets hit.
char
force-pushed
the
char/update-handle-bust-cache
branch
from
9b51a5c to
64a006b
Compare
char
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a self-hosted PDS, updating an account's handle via
com.atproto.identity.updateHandlewon't change the reportedhandlevalue incom.atproto.repo.describeRepo, since the did cache still has stale data.To solve this, we just clear the cache after the updateHandle endpoint gets hit.
what do we think chat