Dev/make kafka optional #313
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacaswell
force-pushed
the
dev/make_kafka_optional
branch
from
a82a52b to
059db8b
Compare
|
In my opinion, the option to automatically create and configure RE instance should be removed completely, because it is not suitable for use in production and confuses new users. This will also remove Kafka dependency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Buries the bluesky-kafka import to where it is actually used.
Motivation and Context
Lighten the default installation weight.
Summary of Changes for Release Notes
Fixed
Added
Changed
Removed
How Has This Been Tested?