Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Everything #288

Merged
merged 6 commits into from
Oct 15, 2024
Merged

Fix Everything #288

merged 6 commits into from
Oct 15, 2024

Conversation

Benjamin-Frost
Copy link
Member

Following the "Update Everything" (#285), here is the "Fix Everything" PR! :)

Things to consider:

  • The 404 page currently redirects to language-specific 404 pages, which changes the URL. This could be something to address in the future.
  • The code could use some cleaning up, particularly for the index page. It might be worth creating a meta page component, similar to SkillsPage, where we can simply pass the translations.

@Benjamin-Frost Benjamin-Frost self-assigned this Oct 15, 2024
Copy link
Member

@JonasWanke JonasWanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like that the structure of the landing page is duplicated, but text in the skill pages is much easier to follow

@Benjamin-Frost
Copy link
Member Author

I don't like that the structure of the landing page is duplicated, but text in the skill pages is much easier to follow

I totally agree! This will be changed in a future PR. I just wanted to get the page up and running asap.

@Benjamin-Frost Benjamin-Frost merged commit 4b2ce41 into main Oct 15, 2024
2 checks passed
@Benjamin-Frost Benjamin-Frost deleted the fix-everything branch October 15, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants