Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Added team data" #303

Closed
wants to merge 1 commit into from
Closed

Revert "Added team data" #303

wants to merge 1 commit into from

Conversation

styrix560
Copy link
Collaborator

Reverts #299

@styrix560
Copy link
Collaborator Author

styrix560 commented Oct 29, 2024

For some reason in prod the whole page breaks

@styrix560 styrix560 requested review from JonasWanke and Benjamin-Frost and removed request for JonasWanke October 29, 2024 13:39
@styrix560
Copy link
Collaborator Author

Skill names are now [object Object] which is fair enough, because I just assumed if there are no type errors then everything should be fine. I have no idea why the images are broken.

@styrix560 styrix560 requested review from JonasWanke and removed request for Benjamin-Frost October 29, 2024 13:50
@styrix560
Copy link
Collaborator Author

If you approve of these changes, please merge it also. I will take a look at it (and hope I dont have to do it the Astro-way because that one sucks) when I have time tomorrow.

@Benjamin-Frost
Copy link
Member

Benjamin-Frost commented Oct 29, 2024

Skill names are now [object Object] which is fair enough, because I just assumed if there are no type errors then everything should be fine. I have no idea why the images are broken.

This should be an easy fix. You used /src/assets/img/team/x as image paths which don't exist after building. Maybe this is helpful:

@Benjamin-Frost
Copy link
Member

See #304

@JonasWanke JonasWanke deleted the revert-299-team-page branch October 30, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants