Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PriorityQueue.kt #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

imcasper
Copy link

"arr" will never be increased for "capacity <= 0"

"arr" will never be increased for "PriorityQueue(0)"
@codecov-io
Copy link

codecov-io commented Sep 14, 2019

Codecov Report

Merging #6 into master will decrease coverage by 0.07%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master       #6      +/-   ##
============================================
- Coverage     62.82%   62.74%   -0.08%     
  Complexity      265      265              
============================================
  Files            47       47              
  Lines           858      859       +1     
  Branches        177      178       +1     
============================================
  Hits            539      539              
  Misses          278      278              
- Partials         41       42       +1
Impacted Files Coverage Δ Complexity Δ
.../uuddlrlrba/ktalgs/datastructures/PriorityQueue.kt 75.51% <66.66%> (-1.58%) 14 <1> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c05287...bc2f2bd. Read the comment docs.

@bmaslakov
Copy link
Owner

bmaslakov commented Jan 15, 2020

Thanks for submitting the suggestion, would you mind changing tabs to spaces to keep it consistent with the rest of the codebase?

Can you add a test for the exception, too?

@imcasper
Copy link
Author

I have corrected

@imcasper
Copy link
Author

I think need use for testing kotlin-test-common
Then the test will become trivial

assertFails {
   PriorityQueue <Int> (0)
}

I also think to separate the library from Java. Is it interesting to you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants